Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dynamic mapping update in testTransportBulkTasks #38073

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 31, 2019

If a replica does not have a right mapping yet, we will retry the index request on that replica; then the actual tasks is higher than the expected tasks. Since #31140 this happens more frequently for we no longer require acking on the dynamic mapping of index requests.

Relates #31140
Closes #37893

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests v7.0.0 v6.7.0 labels Jan 31, 2019
@dnhatn dnhatn added the :Distributed/Task Management Issues for anything around the Tasks API - both persistent and node level. label Jan 31, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but maybe let @ywelsch double check :))

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Jan 31, 2019

@original-brownbear @ywelsch thanks for reviewing.

@dnhatn dnhatn merged commit 237fcda into elastic:master Jan 31, 2019
@dnhatn dnhatn deleted the test-task-bulk branch January 31, 2019 18:16
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 1, 2019
If a replica does not have a right mapping yet, we will retry the index
request on that replica; then the actual tasks is higher than the
expected tasks. Since elastic#31140 this happens more frequently for we no
longer require acking on the dynamic mapping of index requests.

Relates elastic#31140
Closes elastic#37893
dnhatn added a commit that referenced this pull request Feb 1, 2019
If a replica does not have a right mapping yet, we will retry the index
request on that replica; then the actual tasks is higher than the
expected tasks. Since #31140 this happens more frequently for we no
longer require acking on the dynamic mapping of index requests.

Relates #31140
Closes #37893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Task Management Issues for anything around the Tasks API - both persistent and node level. >test Issues or PRs that are addressing/adding tests v6.7.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants